Corrected all asserts with exit(EXIT_FAILURE)#2
Open
vickvey wants to merge 1 commit intoAlexanderAgd:masterfrom
Open
Corrected all asserts with exit(EXIT_FAILURE)#2vickvey wants to merge 1 commit intoAlexanderAgd:masterfrom
vickvey wants to merge 1 commit intoAlexanderAgd:masterfrom
Conversation
vickvey
commented
Oct 11, 2024
- assert.h should not be in production code.
- We are already printing the error messages but was using assert() as a break point to break the program in between, this might not be a great idea as assert also exposes the source variables in the console or so.
- I replaced it with exit(EXIT_FAILURE) as it is more robust way of exiting the program, It helps us in hiding the source variables info which were exposed in assert() and gives us a robust way of exiting a program.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.